Skip to content

Remove unnecessary dependencies #178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Remove unnecessary dependencies #178

wants to merge 1 commit into from

Conversation

inosik
Copy link

@inosik inosik commented Feb 27, 2020

This removes packages that are used in the sample projects and some unused packages from the actual Serilog.AspNetCore package.

@sungam3r
Copy link
Contributor

Well, see #127 :)

@inosik
Copy link
Author

inosik commented Feb 27, 2020

Wow! I could not even imagine that it was intended.

+1 😄

Well, @nblumhardt feel free to close this then.

@sungam3r
Copy link
Contributor

I still have a negative attitude towards the decision to include these dependencies in the package.

@nblumhardt
Copy link
Member

Thanks all. I think the original logic is still sound:

something resembling a meta-package is needed if we're going to meet the ease-of-setup expectations set by Microsoft.Extensions.Logging/ASP.NET Core, which includes console and debug logging by default.

but we might meet the same goals by making Serilog.AspNetCore a pure metapackage in the future. Worth considering, anyway!

@nblumhardt nblumhardt closed this Feb 27, 2020
@inosik inosik deleted the remove-unnecessary-dependencies branch February 28, 2020 06:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants